Skip to content

[MOB-9755] Fix ArgsRegistry Import on iOS #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2022
Merged

[MOB-9755] Fix ArgsRegistry Import on iOS #161

merged 2 commits into from
Aug 23, 2022

Conversation

@TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Aug 22, 2022 •
edited
Loading

Description of the change

Flatten the iOS Project structure, by removing the util directory.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN force-pushed the fix/args-registry-import-ios branch from f2d1fe2 to 2a252b8 Compare August 22, 2022 10:06
@TheBuggedYRN TheBuggedYRN force-pushed the fix/args-registry-import-ios branch from 2a252b8 to c9de959 Compare August 22, 2022 10:06
@TheBuggedYRN TheBuggedYRN changed the title [MOB-9755] Fix ArgsRegistry Import on iOS [MOB-9755] Fix ArgsRegistry Import on iOS Aug 22, 2022
@TheBuggedYRN TheBuggedYRN self-assigned this Aug 22, 2022
@TheBuggedYRN TheBuggedYRN linked an issue Aug 22, 2022 that may be closed by this pull request
Wrong import in IBGPlugin.h when building iOS app with Capacitor #160
Closed
AliAbdelfattah
AliAbdelfattah previously approved these changes Aug 22, 2022
View reviewed changes
@ymabdallah ymabdallah merged commit 81dc9d3 into master Aug 23, 2022
@ymabdallah ymabdallah deleted the fix/args-registry-import-ios branch August 23, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AliAbdelfattah AliAbdelfattah Awaiting requested review from AliAbdelfattah

1 more reviewer

@DavidMina96 DavidMina96 DavidMina96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TheBuggedYRN TheBuggedYRN

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong import in IBGPlugin.h when building iOS app with Capacitor

5 participants

@TheBuggedYRN @AliAbdelfattah @DavidMina96 @ymabdallah