Minor improvements

Inspiaaa · Aug 30, 2023 · 73bc304 · 73bc304
1 parent 111f1ee
commit 73bc304
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/src/CoroutineBase.cs b/src/CoroutineBase.cs
@@ -90,6 +90,11 @@ public virtual void OnChildStopped(CoroutineBase child)
         /// </summary>
         public void Kill()
         {
+            if (!isAlive)
+            {
+                return;
+            }
+
             try
             {
                 OnExit();

diff --git a/src/Coroutines/Coroutine.cs b/src/Coroutines/Coroutine.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections;
+using System.ComponentModel;
 
 namespace HCoroutines
 {
@@ -46,7 +47,7 @@ public override void Update()
             object obj = routine.Current;
 
             // yield return null; => do nothing.
-            if (obj == null)
+            if (obj is null)
             {
                 return;
             }

diff --git a/src/Util/TimeScheduler.cs b/src/Util/TimeScheduler.cs
@@ -34,7 +34,15 @@ public int ScheduleOnSignal(Action action, Godot.Object obj, string signal)
         {
             int id = GetNextScheduleId();
             actionsById[id] = action;
-            obj.Connect(signal, this, "CallCallback", new Godot.Collections.Array(id), (int)ConnectFlags.Oneshot);
+
+            obj.Connect(
+                signal,
+                this,
+                nameof(CallCallback),
+                new Godot.Collections.Array(id),
+                (int)ConnectFlags.Oneshot
+            );
+
             return id;
         }