-
Notifications
You must be signed in to change notification settings - Fork 22
BUG: Do not clobber auditwheel manylinux module wheel #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thewtex
merged 1 commit into
InsightSoftwareConsortium:release
from
thewtex:auditwheel-clobber
Mar 6, 2025
Merged
BUG: Do not clobber auditwheel manylinux module wheel #291
thewtex
merged 1 commit into
InsightSoftwareConsortium:release
from
thewtex:auditwheel-clobber
Mar 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mv is overwriting the manylinux wheel that auditwheel generated previously. This wheel contains the fixed up shared library that points to libtbb from the itk-core package. Otherwise, this will result in: ImportError: libtbb.so.12: cannot open shared object file: No such file or directory at runtime on systems without that library.
dzenanz
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SimonRit
pushed a commit
to SimonRit/ITKCudaCommon
that referenced
this pull request
Mar 6, 2025
thewtex
added a commit
to thewtex/ITKRemoteModuleBuildTestPackageAction
that referenced
this pull request
Mar 6, 2025
thewtex
added a commit
to thewtex/ITKSplitComponents
that referenced
this pull request
Mar 6, 2025
thewtex
added a commit
to thewtex/ITKSplitComponents
that referenced
this pull request
Mar 6, 2025
thewtex
added a commit
to thewtex/ITKSplitComponents
that referenced
this pull request
Mar 6, 2025
thewtex
added a commit
to thewtex/ITKSplitComponents
that referenced
this pull request
Mar 6, 2025
thewtex
added a commit
to thewtex/ITKCuberille
that referenced
this pull request
Mar 6, 2025
Addresses libtbb Linux Python package issue: InsightSoftwareConsortium/ITKPythonPackage#291
SimonRit
pushed a commit
to SimonRit/ITKCudaCommon
that referenced
this pull request
Mar 7, 2025
SimonRit
pushed a commit
to RTKConsortium/ITKCudaCommon
that referenced
this pull request
Mar 11, 2025
SimonRit
pushed a commit
to SimonRit/RTK
that referenced
this pull request
Mar 11, 2025
SimonRit
pushed a commit
to RTKConsortium/RTK
that referenced
this pull request
Mar 12, 2025
axel-grc
pushed a commit
to axel-grc/RTK
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mv is overwriting the manylinux wheel that auditwheel generated previously. This wheel contains the fixed up shared library that points to libtbb from the itk-core package. Otherwise, this will result in:
ImportError: libtbb.so.12: cannot open shared object file: No such file or directory
at runtime on systems without that library.