BUG: Set FastMarching targets prior to reach mode #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With updates to FastMarching in ITK, it is necessary to SetTargetPoints prior to setting TargetReachMode. Without this change, an exception is thrown in itkFastMarchingUpwindGradientImageFilter:: VerifyTargetReachedModeConditions() when called by SetTargetReachedModeToAllTargets() which is called by itkSpeedfunctionToPathFilter:: ComputeArrivalFunction()
This was referenced Jul 6, 2022
dzenanz
approved these changes
Jul 6, 2022
aylward
added a commit
to InsightSoftwareConsortium/ITK
that referenced
this pull request
Aug 8, 2022
* ENH: Bump MinimalPathExtraction module to v1.2.2 # Changes * COMP: Remove inclusion of .hxx files as headers by @hjmjohnson in * InsightSoftwareConsortium/ITKMinimalPathExtraction#86 * COMP: Modules need updated version of ITK by @hjmjohnson in * InsightSoftwareConsortium/ITKMinimalPathExtraction#87 * BUG: Set FastMarching targets prior to reach mode by @aylward in * InsightSoftwareConsortium/ITKMinimalPathExtraction#90 * ENH: Bump ITK and replace http with https using script by @tbirdso in * InsightSoftwareConsortium/ITKMinimalPathExtraction#89 * ENH: Update Python package for itk-5.3rc4 by @thewtex in * InsightSoftwareConsortium/ITKMinimalPathExtraction#88 * ENH: Bump ITK to v5.3rc04(.post2) by @aylward in * InsightSoftwareConsortium/ITKMinimalPathExtraction#93 * @tbirdso made their first contribution in * InsightSoftwareConsortium/ITKMinimalPathExtraction#89 **Full Changelog**: InsightSoftwareConsortium/ITKMinimalPathExtraction@v1.2.0...v1.2.1 * ENH: Bump MinimalPathExtraction to v1.2.2 v1.2.1 had a minor bug that would have prevented it from correctly resolving future versions of ITK See https://github.com/InsightSoftwareConsortium/ITKMinimalPathExtraction/releases/tag/v1.2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With updates to FastMarching in ITK, it is necessary to
SetTargetPoints prior to setting TargetReachMode.
Without this change, an exception is thrown in
itkFastMarchingUpwindGradientImageFilter::
VerifyTargetReachedModeConditions() when called by
SetTargetReachedModeToAllTargets()
which is called by itkSpeedfunctionToPathFilter::
ComputeArrivalFunction()