BUG: Fix failing filter and KW-Style tests #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
reviewed
Apr 22, 2020
The filters were originlly setup to utilize the new Multi-threader format. However, these filters utilize a custom region splitter that requires the classic multi-threader. The changes required changing: - DynamiicMultThreadingOn() to DynamiicMultThreadingOff() in filter's constructor, in order to utilize classic multi-threader - DynamicThreadedGenerateData() to ThreadedGenerateData with theadId passed as a parameter - Add ProgressReporter object as parameter to doOneDimension methods.
mseng10
force-pushed
the
fix-failing-tests
branch
from
cead68f
to
38b50c4
Compare
dzenanz
approved these changes
Apr 22, 2020
|
This fixes #27, closing issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
dimtoDimfixes the failing KWStyle test thrown for this module.For the filters, these changes address #27. They had to be reverted to the classic ITK multi-threading system, because they utilize a custom region splitter. This required:
DynamiicMultThreadingOn()toDynamiicMultThreadingOff()in filter's constructor.Changing method
DynamicThreadedGenerateData()toThreadedGenerateData()withtheadIdpassed as a parameter.Adding
ProgressReporterobject as parameter todoOneDimension()methods.