ENH: Increase itk::PhaseAnalysisSoftThresholdImageFilter class coverage. #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phcerdan
reviewed
May 31, 2017
| std::cerr << "Error in GetThreshold()" << std::endl; | ||
| std::cerr << "Expected: " << expectedThreshold << ", but got: " | ||
| << computedThreshold << std::endl; | ||
| return EXIT_FAILURE; |
Collaborator
There was a problem hiding this comment.
Can you instead of exiting the test immediately, use a variable: bool testPassed = true; And then return EXIT_FAILURE or SUCCESS based on that variable? The good thing about this is that all parts of the test are executed, so we can correct it all at once, or have a more general idea what's going on.
See for example: https://github.com/phcerdan/ITKIsotropicWavelets/blob/0506972375509bfaf5b228ee108477044c6fcd2d/test/itkHeldIsotropicWaveletTest.cxx#L80
Exercise the Set/Get NumOfSigmas methods, and perform regression tests for the m_MeanAmp, m_SigmaAmp, and m_Threshold ivars to make exercising their Get macros relevant. Modify the CMakeLists.txt to accept the new test input values and the expected values for the class regression tests.
jhlegarreta
force-pushed
the
IncreasePhaseAnalysisSoftThresholdImageFilterCoverage
branch
from
6b609a3 to
c688023
Compare
Member
Author
|
@phcerdan Done ! Also took advantage to rebase after latest merges. |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise the Set/Get NumOfSigmas methods, and perform regression tests
for the m_MeanAmp, m_SigmaAmp, and m_Threshold ivars to make exercising
their Get macros relevant.
Modify the CMakeLists.txt to accept the new test input values and the
expected values for the class regression tests.