BUG: Fix failing example #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseng10
force-pushed
the
clean-remote-modules
branch
from
04d2fc5 to
23ba83b
Compare
Contributor
Author
|
@hjmjohnson It seems the only errors being thrown are related to the KWStyle checking which should be handled in the ITKv5_1rc2 merge. Should I rebase the changes on top of that branch, or keep this as a WIP until it is merged? |
Member
|
@mseng10. rebase on top of master, ensure that a clean build occurs with the master of ITK, and the master of all remote modules. |
mseng10
force-pushed
the
clean-remote-modules
branch
from
23ba83b to
fa988a5
Compare
hjmjohnson
approved these changes
Apr 14, 2020
mseng10
force-pushed
the
clean-remote-modules
branch
4 times, most recently
from
cb0ffc9 to
3388fa1
Compare
Contributor
Author
|
Recent changes remove the old ci testing to fit the new ITKModuleTemplate. New ci testing will be implemented in #40. Also, I changed the azure-pipeline |
Member
|
@mseng10 please try re-basing on |
I have included a Data subdirectory in AnisotropicDiffusionLBR/examples/Data and upload the raw png file used for the example's test. In addition, the image was not being properly read, so I required the ITKIOImageBase module be imported for proper reading.
mseng10
force-pushed
the
clean-remote-modules
branch
from
3388fa1 to
1eff30f
Compare
Contributor
Author
thewtex
approved these changes
May 4, 2020
Member
|
Appveyor, TravisCI, and CircleCI services have been disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have included a Data subdirectory in
AnisotropicDiffusionLBR/examples/Dataand uploaded the raw png file: PacMan.png. This is used for the example's test, and any user who may wish to experiment with the module.In addition, the image was not being properly read, so I required the ITKIOImageBase module be imported for proper reading.
Lastly, a minor spelling error was fixed.
This PR is a WIP, I will update it based on these test results.