Skip to content

BUG: Fix duplicate output files in Convolution streaming tests #5714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
N-Dekker merged 1 commit into from
Jan 6, 2026
+4 −4
Merged

BUG: Fix duplicate output files in Convolution streaming tests #5714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Modules/Filtering/Convolution/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,11 +641,11 @@ itk_add_test(
ITKConvolutionTestDriver
--compare
DATA{Baseline/itkConvolutionImageFilterStreamingTestOutput.mha}
${ITK_TEST_OUTPUT_DIR}/itkConvolutionImageFilterStreamingTestOutput.mha
${ITK_TEST_OUTPUT_DIR}/itkConvolutionImageFilterStreamingValidTestOutput.mha
itkConvolutionImageFilterStreamingTest
spatial
DATA{Input/cthead1.mha}
${ITK_TEST_OUTPUT_DIR}/itkConvolutionImageFilterStreamingTestOutput.mha
${ITK_TEST_OUTPUT_DIR}/itkConvolutionImageFilterStreamingValidTestOutput.mha
50
75
150
Expand All @@ -658,11 +658,11 @@ itk_add_test(
ITKConvolutionTestDriver
--compare
DATA{Baseline/itkConvolutionImageFilterStreamingTestOutput.mha}
${ITK_TEST_OUTPUT_DIR}/itkFFTConvolutionImageFilterStreamingTestOutput.mha
${ITK_TEST_OUTPUT_DIR}/itkFFTConvolutionImageFilterStreamingValidTestOutput.mha
itkConvolutionImageFilterStreamingTest
frequency
Copy link
Member Author

@blowekamp blowekamp Jan 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-Dekker Here is case where the test name is "itkFFTConvolutionImageFilterStreamingValidTest" not the "valid" but here the "frequency" command line argument is used. So there is some pre-existing inconsistencies that could be corrected to make the + "Output.mha" work. But later "valid" is used for the region mode.

DATA{Input/cthead1.mha}
${ITK_TEST_OUTPUT_DIR}/itkFFTConvolutionImageFilterStreamingTestOutput.mha
${ITK_TEST_OUTPUT_DIR}/itkFFTConvolutionImageFilterStreamingValidTestOutput.mha
50
75
150
Expand Down
Loading