BUG: Fix kw commit msg checking #5433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The github 'ghostworkflow' fails when the subject line is greater than 78 characters in length. Add a check to enforce the subject line length during initial commit when it is easy to fix. The function 'hooks_config' does not exist, so it always failed and prevented the script from performing the intended task. The testing for correct ITK commit prefix was migrated form commit-msg to this script.
The commit-msg script is never used. It was replaced with kw-commit-msg script that is called for pre-commit.
github-actions
bot
added
type:Bug
Member
|
#5434 seems like a duplicate of this? |
Member
Author
It is not a duplicate of the previous. This PR is fixing the bash script with bash commands, and these fixes are immediately useful in other tools that use kw-commit-msg (i.e. SphinxExamples, SimpleITK, ..). The #5434 is a conversion from bash to python. If #5434 is rejected, this PR is essential. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-commit hook for checking commit messages was not being
executed.
The commit-msg hook was never used. The kw-commit-msg hook seems
to be the script to use.
Removed commit-msg and migrated useful components to kw-commit-msg.
PR Checklist
NOTES
The following copies in other projects may also need to be updated.