Skip to content

Conversation

@seanm
Copy link
Contributor

@seanm seanm commented Jun 20, 2025

  • removed workaround for Xcode 10
  • emit #error for AppleClang less than Xcode 12.4
  • removed workaround for broken fail() added in 1fcd007 in 2003. Hopefully the workaround is no longer needed. I'm not sure, but all tests pass on my arm64 macOS 15.5.

Related to issue #5369.

@seanm
Copy link
Contributor Author

seanm commented Jun 20, 2025

Not sure about the 1 commit for the fail() failure...

@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:Core Issues affecting the Core module area:IO Issues affecting the IO module labels Jun 20, 2025
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good.

- removed workaround for Xcode 10
- emit #error for AppleClang less than Xcode 12.4
- removed workaround for broken fail() added in 1fcd007 in 2003. Hopefully the workaround is no longer needed. I'm not sure, but all tests pass on my arm64 macOS 15.5.

Related to issue InsightSoftwareConsortium#5369.
@seanm seanm force-pushed the old-mac-workarounds branch from 045d04f to 6771697 Compare June 20, 2025 17:51
@thewtex thewtex merged commit 37c1406 into InsightSoftwareConsortium:master Jun 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Core Issues affecting the Core module area:IO Issues affecting the IO module type:Compiler Compiler support or related warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants