Make GetComponentTypeAsString and GetPixelTypeAsString functions static
#5391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made all `GetComponentTypeAsString` and `GetPixelTypeAsString` member functions static. Follow-up to commit 2cedb03, "ENH: Make string/type conversion functions static in ImageIOBase", David Doria, May 10, 2011.
Replaced function calls of the form `instance->MemberFunction(x)` with `T::MemberFunction(x)`, for the static member functions `GetPixelTypeAsString` and `GetComponentTypeAsString`. Following https://clang.llvm.org/extra/clang-tidy/checks/readability/static-accessed-through-instance.html ("Checks for member expressions that access static members through instances").
github-actions
bot
added
area:IO
dzenanz
approved these changes
Jun 12, 2025
hjmjohnson
approved these changes
Jun 12, 2025
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Jun 20, 2025
Replaced function calls of the form `instance->MemberFunction(x)` with `itk::T::MemberFunction(x)`, for the static member functions `GetPixelTypeAsString` and `GetComponentTypeAsString`. Follow-up to pull request InsightSoftwareConsortium#5391 commit 45e93bb
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Jun 20, 2025
Replaced function calls of the form `instance->MemberFunction(x)` with `itk::T::MemberFunction(x)`, for the static member functions `GetPixelTypeAsString` and `GetComponentTypeAsString`. Removed the non-static version of the string <-> type conversion tests from itkImageIOBaseTest. Follow-up to pull request InsightSoftwareConsortium#5391 commit 45e93bb
hjmjohnson
pushed a commit
that referenced
this pull request
Jun 20, 2025
Replaced function calls of the form `instance->MemberFunction(x)` with `itk::T::MemberFunction(x)`, for the static member functions `GetPixelTypeAsString` and `GetComponentTypeAsString`. Removed the non-static version of the string <-> type conversion tests from itkImageIOBaseTest. Follow-up to pull request #5391 commit 45e93bb
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Jun 21, 2025
Replaced function calls of the form `instance->MemberFunction(x)` with `itk::T::MemberFunction(x)`, for the static member functions `GetPixelTypeAsString` and `GetComponentTypeAsString, in Examples. Follow-up to pull request InsightSoftwareConsortium#5391 commit 45e93bb
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Jun 21, 2025
Replaced function calls of the form `instance->MemberFunction(x)` with `itk::T::MemberFunction(x)`, for the static member functions `GetPixelTypeAsString` and `GetComponentTypeAsString`, in Examples. Follow-up to pull request InsightSoftwareConsortium#5391 commit 45e93bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to commit 2cedb03, "ENH: Make string/type conversion functions static in ImageIOBase", David Doria, May 10, 2011.
Adjusted the calls to those member functions, following clang-tidy static-accessed-through-instance ("Checks for member expressions that access static members through instances").