STYLE: Replace rand() calls with std::mt19937 in ImageAdaptor test
#5348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernized the code. Also improved the style, by removing `static_cast<float>`s.
github-actions
bot
added
type:Testing
dzenanz
approved these changes
May 14, 2025
N-Dekker
commented
May 14, 2025
Comment on lines
-42
to
+44
| auto randMax = static_cast<float>(RAND_MAX); | ||
| const PixelType pixel(static_cast<float>(rand()) / randMax, static_cast<float>(rand()) / randMax); | ||
| const PixelType pixel(randomNumberDistribution(randomNumberEngine), randomNumberDistribution(randomNumberEngine)); |
Contributor
Author
There was a problem hiding this comment.
For the record, this pull request was inspired by a discussion we had before about the use of static_cast<float>(RAND_MAX), at #5337 (comment) It appeared that RAND_MAX is platform dependent, so this static_cast<float> may or may not be lossless. Which made me want to get rid of static_cast<float>(RAND_MAX) 👹 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernized the code. Also improved the style, by removing
static_cast<float>s.