Skip to content

FUTURE REMOVE MersenneTwisterRandomVariateGenerator::Initialize #5346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thewtex merged 2 commits into from
May 15, 2025
Merged

FUTURE REMOVE MersenneTwisterRandomVariateGenerator::Initialize #5346

thewtex merged 2 commits into from
May 15, 2025

Conversation

@N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented May 13, 2025

The MersenneTwisterRandomVariateGenerator member function Initialize behaves just like SetSeed, but SetSeed is more commonly used, and clearer.

N-Dekker added 2 commits May 13, 2025 17:25
@N-Dekker
STYLE: Replace Initialize calls random number generator with SetSeed
7bb3671 
The two MersenneTwisterRandomVariateGenerator member functions `Initialize` and
`SetSeed` behave the same, but `SetSeed` is more commonly used, and clearer.
@N-Dekker
STYLE: FUTURE REMOVE MersenneTwisterRandomVariateGenerator::Initialize
83328fb 
The MersenneTwisterRandomVariateGenerator member function `Initialize` behaves
just like `SetSeed`, but `SetSeed` is more commonly used, and clearer.
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Numerics Issues affecting the Numerics module labels May 13, 2025
dzenanz
dzenanz approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance.

@N-Dekker N-Dekker marked this pull request as ready for review May 13, 2025 22:20
@N-Dekker
Copy link
Contributor Author

N-Dekker commented May 15, 2025

Thanks for your approval @dzenanz 👍

By the way, I find the name MersenneTwisterRandomVariateGenerator::Initialize especially confusing, because it seems to suggest that a newly created MersenneTwisterRandomVariateGenerator is still uninitialized! But actually, an instance created by MersenneTwisterRandomVariateGenerator::New() can be used directly, without calling Initialize!

thewtex
thewtex approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thewtex thewtex merged commit 68bcf62 into InsightSoftwareConsortium:master May 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@N-Dekker @thewtex @dzenanz