ENH: Test Linux ARM in CI#5137
Draft
thewtex wants to merge 7 commits intoInsightSoftwareConsortium:mainfrom
Draft
ENH: Test Linux ARM in CI#5137thewtex wants to merge 7 commits intoInsightSoftwareConsortium:mainfrom
thewtex wants to merge 7 commits intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
bot
added
type:Infrastructure
hjmjohnson
force-pushed
the
linux-arm-ci
branch
from
7bd8b6d to
d3ac3f3
Compare
hjmjohnson
approved these changes
Jan 29, 2026
Member
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
@thewtex The code looks good to me. I rebased it the current upstream/main branch
Member
Author
|
@hjmjohnson thanks, but the workflow is invalid: https://github.com/InsightSoftwareConsortium/ITK/actions/runs/21444681186/workflow And there are also test failures and warnings that need to be addressed. |
hjmjohnson
force-pushed
the
linux-arm-ci
branch
3 times, most recently
from
b9bb4d6 to
d77f751
Compare
Member
|
Build occurs O.K. but the following tests have failures: I think the CI component is working as expected, but some code changes are needed to build on Linux ARM environments. |
GitHub Actions Linux ARM runners are now available for free for open source projects. https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
Remove the excessively verbose '-VV' ctest flags that make identifying errors in the online logs very difficult.
Reduce duplication of common testing. Introduce reusable `AddMetaData` and `VerifyMetaData` functions to eliminate redundant metadata handling code in `HDF5ImageIOTest` and `MetaDataDictionaryGTest`. This simplifies test logic and improves maintainability. Provide more failure diagnostics to assist with pin-pointing the failure locations.
This ensures that each dictionary item is printed on a newline.
Make tracking down failures easier to trace
Replace `dynamic_cast` with `static_cast` and explicit type information checks for clearer and more efficient metadata handling.
Simplify and reformat macro usage for improved readability and maintainability, removing unnecessary line breaks and ensuring consistent structure.
hjmjohnson
force-pushed
the
linux-arm-ci
branch
from
f909911 to
daab23b
Compare
github-actions
bot
added
type:Testing
Member
|
FYI: I think the crux of the problem lies in how MetaData is handled in ITK for HDF5 image IO. Failure ExposeMetaData 'TestBool'
Failure ExposeMetaData 'TestUChar'
Incorrect meta value read in for TestUChar '
' != 'u' |
Member
|
The meta data components of the hd5 file written to disk are different on M3 mac for mac build vs docker linxu-arm build: h5dump ./Testing/Temporary/ITKIOHDF5/RGBImage.hdf5 ~/PASS_MAC
h5dump ./Testing/Temporary/ITKIOHDF5/RGBImage.hdf5 > ~/FAIL_LINUX
vimdiff ~/PASS_MAC ~/FAIL_LINUX
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions Linux ARM runners are now available for free for open
source projects.
https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
Depends on: