Skip to content

STYLE: Replace "the the" with "the" in comments #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2024
Merged

STYLE: Replace "the the" with "the" in comments #4532

merged 1 commit into from
Mar 23, 2024

Conversation

@N-Dekker
Copy link
Contributor

The word "the" often appears accidentally duplicated, both in regular and doxygen formatted comments.

@N-Dekker
STYLE: Replace "the the" with "the" in comments
e81746c 
The word "the" often appears accidentally duplicated, both in regular and
doxygen formatted comments.
@N-Dekker N-Dekker requested review from dave3d and jhlegarreta March 22, 2024 14:13
@github-actions github-actions bot added area:Python wrapping Python bindings for a class type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) area:Numerics Issues affecting the Numerics module labels Mar 22, 2024
@N-Dekker
Copy link
Contributor Author

N-Dekker commented Mar 22, 2024 •
edited
Loading

Slightly off-topic 😸: The The is actually one of my favorite bands of the eighties... and they are going on tour again!!!

@N-Dekker N-Dekker marked this pull request as ready for review March 22, 2024 16:06
@dave3d
Copy link
Member

dave3d commented Mar 22, 2024

My wife, who was born in Taiwan, is always asking what's the point of articles and grammar? She thinks it's a waste of time, being a Taiwanese/Chinese speaker.

@dzenanz
Copy link
Member

dzenanz commented Mar 22, 2024

Being a Slavic speaker, I frequently swallow articles too. Less so recently, with AI spell checkers which let me know when I forget them 😄

@hjmjohnson hjmjohnson merged commit b4f0bb8 into InsightSoftwareConsortium:master Mar 23, 2024
@N-Dekker
Copy link
Contributor Author

@dave3d @dzenanz Based on your comments, I'm now considering a pull request to just remove all "the"'s from the source tree, not just "the the" and "the the the". 😸

N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 25, 2024
@N-Dekker
STYLE: Replace "the the" with "the" in itkGradientImageFilter.h
aff1dac 
Follow-up to pull request InsightSoftwareConsortium#4532
commit b4f0bb8
STYLE: Replace "the the" with "the" in comments
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Apr 1, 2024
@N-Dekker
STYLE: Replace "the the" with "the" in itkGradientImageFilter.h
573facd 
Follow-up to pull request InsightSoftwareConsortium#4532
commit b4f0bb8
STYLE: Replace "the the" with "the" in comments
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Apr 2, 2024
@N-Dekker
STYLE: Replace "the the" with "the" in itkGradientImageFilter.h
fa39e81 
Follow-up to pull request InsightSoftwareConsortium#4532
commit b4f0bb8
STYLE: Replace "the the" with "the" in comments
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Apr 9, 2024
@N-Dekker
STYLE: Replace "the the" with "the" in comments
1534e8a 
Following ITK pull request InsightSoftwareConsortium/ITK#4532 commit InsightSoftwareConsortium/ITK@b4f0bb8
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Apr 9, 2024
@N-Dekker
STYLE: Replace "the the" with "the" in comments
78cec4b 
Following ITK pull request InsightSoftwareConsortium/ITK#4532 commit InsightSoftwareConsortium/ITK@b4f0bb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

@jhlegarreta jhlegarreta Awaiting requested review from jhlegarreta

+1 more reviewer

@dave3d dave3d dave3d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Python wrapping Python bindings for a class area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@N-Dekker @dave3d @dzenanz @hjmjohnson