STYLE: Use std::unique_ptr for GradientImageFilter::m_BoundaryCondition #4512
+9
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Filtering
thewtex
approved these changes
Mar 13, 2024
N-Dekker
force-pushed
the
unique_ptr-GradientImageFilter-m_BoundaryCondition
branch
from
efa706c to
718b6bd
Compare
Following C++ Core Guidelines, February 15, 2024, "Use `unique_ptr` or `shared_ptr` to avoid forgetting to `delete` objects created using `new`", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-smart Defaulted the destructor of `GradientImageFilter`.
N-Dekker
force-pushed
the
unique_ptr-GradientImageFilter-m_BoundaryCondition
branch
from
718b6bd to
2f4f838
Compare
dzenanz
approved these changes
Mar 13, 2024
N-Dekker
commented
Mar 13, 2024
blowekamp
approved these changes
Mar 15, 2024
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 25, 2024
Added `GradientImageFilter::OverrideBoundaryCondition` overload, to allows specifying the argument by a `unique_ptr`. Aims to make it more clear that the filter takes the ownership of the specified `BoundaryCondition` object. Triggered by a comment from Bradley Lowekamp at InsightSoftwareConsortium#4512 (comment) on March 13, 2024.
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 25, 2024
Added `GradientImageFilter::OverrideBoundaryCondition` overload, to allows specifying the argument by a `unique_ptr`. Aims to make it more clear that the filter takes the ownership of the specified `BoundaryCondition` object. Triggered by a comment from Bradley Lowekamp at InsightSoftwareConsortium#4512 (comment) on March 13, 2024.
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Apr 1, 2024
Added `GradientImageFilter::OverrideBoundaryCondition` overload, to allows specifying the argument by a `unique_ptr`. Aims to make it more clear that the filter takes the ownership of the specified `BoundaryCondition` object. Triggered by a comment from Bradley Lowekamp at InsightSoftwareConsortium#4512 (comment) on March 13, 2024.
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Apr 2, 2024
Added `GradientImageFilter::OverrideBoundaryCondition` overload, to allows specifying the argument by a `unique_ptr`. Aims to make it more clear that the filter takes the ownership of the specified `BoundaryCondition` object. Triggered by a comment from Bradley Lowekamp at InsightSoftwareConsortium#4512 (comment) on March 13, 2024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following C++ Core Guidelines, "Use
unique_ptrorshared_ptrto avoid forgetting todeleteobjects created usingnew".Defaulted the destructor of
GradientImageFilter.