Skip to content

PERF: Do not import torch to reduce itk import time #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewtex merged 1 commit into from
Dec 16, 2023
Merged

PERF: Do not import torch to reduce itk import time #4369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Wrapping/Generators/Python/itk/support/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
#
# ==========================================================================*/

import importlib
from importlib.metadata import metadata
import os
import re
import functools
Expand All @@ -24,17 +26,17 @@

_HAVE_XARRAY = False
try:
import xarray as xr
metadata('xarray')

_HAVE_XARRAY = True
except ImportError:
pass
_HAVE_TORCH = False
try:
import torch
metadata('torch')

_HAVE_TORCH = True
except ImportError:
except importlib.metadata.PackageNotFoundError:
pass


Expand Down Expand Up @@ -84,6 +86,10 @@ def accept_array_like_xarray_torch(image_filter):
If a xarray DataArray is passed as an input, output itk.Image's are converted to xarray.DataArray's."""
import numpy as np
import itk
if _HAVE_XARRAY:
import xarray as xr
if _HAVE_TORCH:
import torch

@functools.wraps(image_filter)
def image_filter_wrapper(*args, **kwargs):
Expand Down
16 changes: 9 additions & 7 deletions Wrapping/Generators/Python/itk/support/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
#
# ==========================================================================*/

import importlib
from importlib.metadata import metadata
from typing import Union, Optional, Tuple, TYPE_CHECKING
import os

Expand All @@ -26,17 +28,17 @@

_HAVE_XARRAY = False
try:
import xarray as xr
metadata('xarray')

_HAVE_XARRAY = True
except ImportError:
except importlib.metadata.PackageNotFoundError:
pass
_HAVE_TORCH = False
try:
import torch
metadata('torch')

_HAVE_TORCH = True
except ImportError:
except importlib.metadata.PackageNotFoundError:
pass

# noinspection PyPep8Naming
Expand Down Expand Up @@ -218,11 +220,11 @@ def initialize_c_types_once() -> (
ImageOrImageSource = Union[ImageBase, ImageSource]
# Can be coerced into an itk.ImageBase
if _HAVE_XARRAY and _HAVE_TORCH:
ImageLike = Union[ImageBase, ArrayLike, xr.DataArray, torch.Tensor]
ImageLike = Union[ImageBase, ArrayLike, "xr.DataArray", "torch.Tensor"]
elif _HAVE_XARRAY:
ImageLike = Union[ImageBase, ArrayLike, xr.DataArray]
ImageLike = Union[ImageBase, ArrayLike, "xr.DataArray"]
elif _HAVE_TORCH:
ImageLike = Union[ImageBase, ArrayLike, torch.Tensor]
ImageLike = Union[ImageBase, ArrayLike, "torch.Tensor"]
else:
ImageLike = Union[ImageBase, ArrayLike]

Expand Down