Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(PolyDataOutput and MeshOutput): check SharedArrayBuffer #839

Merged
merged 1 commit into from
May 18, 2023
Merged

improvement(PolyDataOutput and MeshOutput): check SharedArrayBuffer #839

merged 1 commit into from
May 18, 2023

Conversation

pritamrungta
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented May 16, 2023 •
edited
Loading

✅ Deploy Preview for itk-wasm-docs ready!

Name Link
🔨 Latest commit 40f5736
🔍 Latest deploy log https://app.netlify.com/sites/itk-wasm-docs/deploys/64647eac9cb7520008d1f0f9
😎 Deploy Preview https://deploy-preview-839--itk-wasm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pritamrungta pritamrungta changed the title check for SharedArrayBuffer in polyData and mesh output transferables improvement(PolyDataOutput and MeshOutput): check SharedArrayBuffer May 16, 2023
@thewtex
Copy link
Member

thewtex commented May 17, 2023

@pritamrungta thank you for the contribution! 🙏

Could the commit message please be updated to change improvement -> fix per

⧗   input: improvement(PolyDataOutput and MeshOutput): check SharedArrayBuffer
5

6
check SharedArrayBuffer in PolyDataOutput and MeshOutput transferables
7
✖   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]
8

9
✖   found 1 problems, 0 warnings
10
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

?

@pritamrungta
fix(PolyDataOutput and MeshOutput): check SharedArrayBuffer
40f5736 
check SharedArrayBuffer in PolyDataOutput and MeshOutput transferables
@pritamrungta
Copy link
Contributor Author

@pritamrungta thank you for the contribution! 🙏

Could the commit message please be updated to change improvement -> fix per

⧗   input: improvement(PolyDataOutput and MeshOutput): check SharedArrayBuffer
5

6
check SharedArrayBuffer in PolyDataOutput and MeshOutput transferables
7
✖   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]
8

9
✖   found 1 problems, 0 warnings
10
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

?

Sure @thewtex I have updated the commit message to change improvement to fix

As a note, my previous commit message was also generated from cz. Maybe we could update the enum types?
image

@thewtex
Copy link
Member

thewtex commented May 17, 2023

Sure @thewtex I have updated the commit message to change improvement to fix

thank you!

As a note, my previous commit message was also generated from cz. Maybe we could update the enum types?

👍 yes.

@thewtex thewtex merged commit c8f3e1d into InsightSoftwareConsortium:main May 18, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-b.109 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pritamrungta @thewtex