Fix itkPipeline help stream parsing crash and native msvc static debug build #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where a call to --help and printing of parameters for a cli app would crash if a description or parameter line did not contain any space.
ITK-Wasm prefers static build. For native build on windows (msvc), it is necessary to enable/specify the use of static runtime debug library indicated by the /MTd compiler flag. Add a CMAKE flag (default: ON) to enable/disable this compiler flag when msvc is being used for building.
|
@thewtex Does the CI pipeline test native building on windows? I want to test this build from scratch on windows. I will just trigger one locally to test anyway. We can merge when it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(itkPipeline): parameters parsing crash when no space in line
Fix a bug where a call to --help and printing of parameters for
a cli app would crash if a description or parameter line
did not contain any space.
build(msvc): add cmake flag to enable msvc static runtime debug library
ITK-Wasm prefers static build. For native build on windows (msvc),
it is necessary to enable/specify the use of static runtime debug
library indicated by the /MTd compiler flag.
Add a CMAKE flag (default: ON) to enable/disable this compiler
flag when msvc is being used for building.