Merged
Conversation
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Contributor
Author
|
Implements #11 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to create VPC (Visual Predictive Check) data by implementing a run_vpc function that generates simulation datasets for pharmacokinetic model validation. The function performs iterative simulations across subjects to produce observation and simulation data suitable for VPC plotting with external packages like vpc.
Key changes:
- New
run_vpcfunction for generating VPC simulation data - Core simulation logic in
run_vpc_corefor individual subjects - Comprehensive test coverage with vancomycin and busulfan model examples
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| R/run_vpc.R | Main implementation with run_vpc and run_vpc_core functions |
| tests/testthat/test-run_vpc.R | Test cases validating VPC functionality with different models |
| man/run_vpc.Rd | Documentation for the main run_vpc function |
| man/run_vpc_core.Rd | Documentation for the core simulation function |
| R/parse_input_data.R | Bug fix for ID assignment in parsed data |
| NAMESPACE | Export declaration for new run_vpc function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
roninsightrx
commented
Sep 30, 2025
| } else { | ||
| p <- function() { } | ||
| } | ||
| p <- if(progress) { progressr::progressor(along = data_parsed) } else { \(x) {} } |
Contributor
Author
There was a problem hiding this comment.
splitting this off as a function didn't work for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function to easily run the simulations to create a VPC. (only data generation, actual vpc plotting is still done using e.g.
vpcpackage).