Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definitions with createdAtStart=true and no qualifier aren't generated correctly #84

Closed
ithersta opened this issue Jun 1, 2023 · 1 comment
Labels
important status:accepted Ticket is accepted and will be planned in a milestone type:issue Something isn't working

Comments

@ithersta
Copy link

ithersta commented Jun 1, 2023

Describe the bug
@Single(createdAtStart = true) with no qualifier generates invalid code

To Reproduce
Steps to reproduce the behavior:

  1. Annotate class with @Single(createdAtStart = true)
  2. Do not specify qualifier
  3. The generated code contains an extra comma and is invalid:
single(,createdAtStart=true) { … }

Expected behavior
The generated code is valid

Koin project used and used version (please complete the following information):
koin-annotations version 1.2.1

@arnaudgiuliani arnaudgiuliani added type:issue Something isn't working status:accepted Ticket is accepted and will be planned in a milestone important labels Jun 5, 2023
@arnaudgiuliani
Copy link
Member

duplicated from InsertKoinIO/koin#1604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important status:accepted Ticket is accepted and will be planned in a milestone type:issue Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants