Skip to content

Support packages with no schemas #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olevitt merged 2 commits into from
Mar 28, 2025
Merged

Support packages with no schemas #577

olevitt merged 2 commits into from
Mar 28, 2025

Conversation

@olevitt
Copy link
Contributor

@olevitt olevitt commented Mar 28, 2025

Currently, if no values.schema.json is provided then the API fails with 500 when resolving the schema.
This PR adds support for packages with no schema :

  • GET /my-lab/schemas/xxx : returns 200 empty if no schema is defined
  • PUT /my-lab/app : skip schema validation if no schema is defined

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@olevitt olevitt added the enhancement New feature or request label Mar 28, 2025
@olevitt olevitt merged commit 3ca798f into main Mar 28, 2025
9 checks passed
@olevitt olevitt deleted the support-no-schemas branch March 28, 2025 10:18
garronej added a commit to InseeFrLab/onyxia that referenced this pull request Mar 28, 2025
@garronej
Support chart without schema InseeFrLab/onyxia-api#577
a16d955
@garronej garronej mentioned this pull request Mar 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olevitt