fix(TidalTags): properly update tags when DOM is recycled#211
Merged
Inrixia merged 1 commit intoInrixia:devfrom Jan 22, 2026
Merged
fix(TidalTags): properly update tags when DOM is recycled#211Inrixia merged 1 commit intoInrixia:devfrom
Inrixia merged 1 commit intoInrixia:devfrom
Conversation
- Add MutationObserver to detect data-track-id attribute changes - Update column content instead of returning early in setColumn - Remove old quality tag span before checking if new one is needed Fixes issue where quality tags and format columns would get misaligned when tracks are removed or reordered in the tracklist.
Inrixia
requested changes
Jan 22, 2026
Owner
Inrixia
left a comment
Inrixia
left a comment
There was a problem hiding this comment.
Looks good, one change needed for observers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-track-idattribute changes when Tidal recycles DOM elementssetColumnFixes issue where quality tags and format columns would get misaligned when tracks are removed or reordered in the tracklist.
Test plan