-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A little bit QoL cleaning up... #84
Conversation
`try_from()` and associated error types for string->enum mappings should go under format/ node data should all be defined under node/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sold on most of these changes.
The introduction of the enums
module is confusing because it doesn't mean anything in particular in regards to the implementation, it just stores various TryFrom
implementations that happen to be currently used by the payload
module. If you put it there because you want to signify that it's for deserializing, we might as well replace these impls with deserialize_[EnumType]
functions within payload
and remove enums
, because a TryFrom
implementation conveys more meaning than its current use case.
I disagree with moving TransformOffset
and InterpMode
to node::data
. At this stage Matrix
would get in there too. It would just put the structs further away from their implementation blocks. I think it's completely fine that someone coming to the codebase excepts TransformOffset
to be in the transform
module.
Rationale for I am fine with file renames or putting the |
On where to put Like, |
Inline enum variant matching, like the rest of `payload.rs`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great now :D
Love it when less code does the same thing.
...that I believe could benefit main before I finish ecs stuff on my own branch.
Put data def and parsing code to proper places:
try_from()
and associated error types for string->enum mappings should go under format/