Skip to content

Commit

Permalink
Don't rethrow exceptions from threads
Browse files Browse the repository at this point in the history
  • Loading branch information
LunaTheFoxgirl committed May 1, 2023
1 parent 0fb87f7 commit 2a06328
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion source/ft/adaptors/ifacialmocap.d
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ public:
if (isRunning) {
// Stop threads
isCloseRequested = true;
listeningThread.join();
listeningThread.join(false);

// Close UDP sockets
dataIn.close();
Expand Down
2 changes: 1 addition & 1 deletion source/ft/adaptors/jinsmemelogger.d
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public:
if (isRunning) {
isCloseRequested = true;
condition.notify();
receivingThread.join();
receivingThread.join(false);
mutex = null;
condition = null;
receivingThread = null;
Expand Down
2 changes: 1 addition & 1 deletion source/ft/adaptors/llf.d
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ public:
// Stop threads
isCloseRequested = true;

listeningThread.join();
listeningThread.join(false);

// Close UDP sockets
llfIn.close();
Expand Down
2 changes: 1 addition & 1 deletion source/ft/adaptors/openseeface.d
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ public:
if (isRunning) {
isCloseRequested = true;
if (receivingThread !is null)
receivingThread.join();
receivingThread.join(false);
osf.close();

receivingThread = null;
Expand Down
4 changes: 2 additions & 2 deletions source/ft/adaptors/vtsproto.d
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ public:
// Stop threads
isCloseRequested = true;

sendingThread.join();
listeningThread.join();
sendingThread.join(false);
listeningThread.join(false);

// Close UDP sockets
vtsIn.close();
Expand Down
2 changes: 1 addition & 1 deletion source/ft/adaptors/webhook.d
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public:
void stop() {
if (isRunning) {
condition.notify();
receivingThread.join();
receivingThread.join(false);
mutex = null;
condition = null;
receivingThread = null;
Expand Down

0 comments on commit 2a06328

Please sign in to comment.