Skip to content

Conversation

@spier
Copy link
Member

@spier spier commented Oct 28, 2021

I noticed that the images for the Community Calls on the Events page did not have the same size.
This lead to the other content below the image (title etc) to be misaligned. See screenshot.

misaligned-event-images

This PR fixes that issue for the existing events.

While at it, I also made various other changes in the same area of the code:

  • Re-create all all event images for the Community Calls (CCs) to 960x540
  • Reduce the file size of all image, to make the page load faster. (we are loading 8 images just for the CCs, so the images got to be reasonably small)
  • Rename images to form meetup-2021-05-04.jpg
  • Consolide filename extension to .jpg (came in various froms before)
  • Rename community events for file format meetup-YYYY-mm-dd.md, to bring them into natural order.
  • Remove date info from the beginning of the event description. When the event has already taken place, the date information isn't that helpful for readers anymore. Also the date info is already available in the image of the title slide.
  • Removing utm campaign info from one eventbrite link (we don't have that info for all other CCs)
  • Remove featured: false as that is the default

@spier
Copy link
Member Author

spier commented Nov 2, 2021

Here how the resulting events page looks like.
event-images-fixed

@spier spier marked this pull request as ready for review November 2, 2021 17:15
Copy link
Member

@claredillon claredillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this Sebastian!

@claredillon claredillon merged commit 9fa1db4 into master Nov 12, 2021
@claredillon claredillon deleted the align-event-images branch November 12, 2021 15:07
@spier
Copy link
Member Author

spier commented Nov 13, 2021

Thanks for review and merge!

I think this is a great improvement already.

There are still some other UI glitches in this area that could still be improved:

  1. Bring the images of the Summits to the same size, or find other ways to make sure that event title etc are aligned
  2. How to align the text if the title breaks into 2 rows?
  3. How to align the Open/Watch buttons horizontally? Maybe that would get fixed together with (2) automatically?
  4. How to prevent repetitive intros like "Join us for an InnerSource Commons Community Call ..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants