Skip to content

#6 fixed issue - third pattern #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2016
Merged

#6 fixed issue - third pattern #7

merged 2 commits into from
Nov 18, 2016

Conversation

HaRo87
Copy link
Contributor

@HaRo87 HaRo87 commented Nov 18, 2016

Hi @gruetter,
here is a first test following your workflow proposal.

gruetter
gruetter requested changes Nov 18, 2016
View reviewed changes
Copy link
Contributor

@gruetter gruetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @HaRo87 . Let's try to make some changes ...

third-test.md

## Problem

Still none.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem here?

third-test.md

## Solution

Similar to _insert pattern link to [First Test](first-test.md)_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links only work for pattern files wich are already on master. At least that's what I found yesterday. Maybe I'm doing it wrong ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're doing it right. From my point of view it is OK. You will only link already existing and reviewed patterns. Otherwise you will leave a todo comment, or?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. Something like this.

@gruetter
Copy link
Contributor

Generally speaking, it seems to work as we planned. Anything missing, @HaRo87 ?

@HaRo87
Copy link
Contributor Author

HaRo87 commented Nov 18, 2016

Looks like it is working @gruetter. How does the stuff with the labels work when you merge?

So we need to document the workflow and publish it at innersourcecommons.org. ;-) We could do that via PR as well and invite the others to review.

@gruetter
Copy link
Contributor

How does the stuff with the labels work when you merge?

Well, let's try it out. I think the labels are preserved.

@gruetter
Copy link
Contributor

Shall I merge?

@HaRo87 HaRo87 merged commit f6e51a7 into master Nov 18, 2016
@gruetter gruetter deleted the newPattern/#6---third-pattern branch December 7, 2016 15:44
spier pushed a commit that referenced this pull request Dec 29, 2022
@WillemJiang
Added the translation of issue-tracker (#7)
ab5c176 
* Added the translation of issue-tracker

* Updated the translation with review comments

* Fixed the markdown lint error
@rrrutledge rrrutledge mentioned this pull request Dec 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruetter gruetter gruetter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaRo87 @gruetter