Render RFC templates in book #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rather than redirecting to github.
spier
requested review from
lenucksi,
NewMexicoKid,
cewilliams,
robtuley and
yuhattor
as code owners
spier
added
the
(Self-) Hosting
|
This was also a nice quick test if merging this PR will immediately update both the en and zh book. This is a benefit that we got from using the monorepo approach (see #578). |
rmarting
pushed a commit
to rmarting/InnerSourcePatterns
that referenced
this pull request
Feb 29, 2024
* Add RFC template to menu of the book. That way it renders in gitbook, rather than redirecting to github. * Adding zh translation of RFC template to the book as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have the README and CONTRIBUTING template embedded directly in our gitbook.
However for some reason we did not do that for the RFC template (referenced in https://patterns.innersourcecommons.org/p/transparent-cross-team-decision-making-using-rfcs).
Changes: