Skip to content

Add a metric for "Improve quality" in introducing-metrics-in-innersource #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

guilhermebrasil
Copy link
Contributor

Regarding code quality improvement, the rework rate captures several software engineering elements. It helps to observe the practical effects of increased code quality, allowing teams to spend most of their time on items that add value to the end users.

Regarding code quality improvement, the rework rate captures several software engineering elements. It helps to observe the practical effects of increased code quality, allowing teams to spend most of their time on items that add value to the end users.
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.
Will be merging this shortly.

Out of curiosity:

  • what qualifies as 'rework'?
  • how can you measure the 'rework rate'?

Also if you know of any online resources related to this, I would be interested in reading more about it.

@spier
Copy link
Member

spier commented Sep 22, 2022

@guilhermebrasil I just merged PR #455, which also changed this pattern.
This seems to lead to a merge conflict.

The GitHub UI does not let me resolve the merge conflict here.
Could you please pull the latest from main and resolve the merge conflict on your branch, and then push again?

@spier spier added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Sep 22, 2022
@guilhermebrasil
Copy link
Contributor Author

@guilhermebrasil I just merged PR #455, which also changed this pattern. This seems to lead to a merge conflict.

The GitHub UI does not let me resolve the merge conflict here. Could you please pull the latest from main and resolve the merge conflict on your branch, and then push again?

OK @spier , I did solve the conflict.

@guilhermebrasil
Copy link
Contributor Author

  • what qualifies as 'rework'?
  • how can you measure the 'rework rate'?

what qualifies as 'rework'?

I like the following definition:

"Rework in software development is the additional effort of redoing a process or activity that was incorrectly implemented in the first instance or due to changes in requirements from clients. It usually results from errors, omissions, failures, changes, poor communications and poor coordination."

Reference: https://airccse.org/journal/ijsea/papers/6515ijsea02.pdf

how can you measure the 'rework rate'?

I am using the % of the time (touch time) a squad spent on correction artifacts in relation to the total development effort (total touch time on all stories/corrections).

@spier spier changed the title Update introducing-metrics-in-innersource.md Add a metric for "Improve quality" in introducing-metrics-in-innersource Sep 23, 2022
@spier spier merged commit 96f539a into InnerSourceCommons:main Sep 23, 2022
@spier
Copy link
Member

spier commented Sep 23, 2022

@dicortazar @NewMexicoKid @rrrutledge what do you think about adding an appendix to this pattern that explains the different metric candidates a bit more, as not all of them are self-explanatory?

The explanations could look similar to what @guilhermebrasil did in the last comment above, including links to references where people can learn more about the metric.

Also if you know of any companies applying this pattern, it would be great to see a PR to push this pattern to the next level ;)

@lenucksi
Copy link
Member

@dicortazar @NewMexicoKid @rrrutledge what do you think about adding an appendix to this pattern that explains the different metric candidates a bit more, as not all of them are self-explanatory?

The explanations could look similar to what @guilhermebrasil did in the last comment above, including links to references where people can learn more about the metric.

Also if you know of any companies applying this pattern, it would be great to see a PR to push this pattern to the next level ;)

Not any of the above, but a metric that is not properly defined yields anecdotal evidence at best. So yes to annex for exactly that. I really like that @guilhermebrasil referenced a proper paper for his rework metric. We need more proper papers tied to in the patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants