Skip to content

pattern/contracted-contributor #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Conversation

nyeates
Copy link
Contributor

@nyeates nyeates commented Jan 17, 2017

Copy link
Contributor

@gruetter gruetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nyeates . I apparently missed the last patterns meeting. What is the current plan? Are we going to user this PR to facilitate the 2nd review of this pattern or are we going to do this in the target repo in the PayPal instance?


**Review comments**

* **(done)** Top level management is aware, expecting savings, putting in money. Is this budget being put into saving capacity for InnerSource? Is a barrier preventing this? Where is that money going? People don't have to hide from top level management.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: remove comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice these in there. I just wholesale copied over for the time being.

We discussed in the meeting that we would like to have ongoing patterns included into master sooner. You look at the repo and it looks like nothing is going on if you dont know to dig into the ongoing PR's. I think we should initially accept pattern PR's, have something out there, and then work on modifications and comments to that base in additional PR's in the same way.

@nyeates nyeates changed the title Pattern/Contracted Contributor pattern/contracted-contributor Jan 19, 2017
@nyeates nyeates merged commit b0fab9e into master Feb 2, 2017
@nyeates nyeates deleted the pattern/contracted-contributor branch February 2, 2017 07:03
spier pushed a commit that referenced this pull request Dec 29, 2022
* Updated the translation of contributing template

* Updated the translation with comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants