Skip to content

Downsize model-loader image #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
InftyAI-Agent merged 1 commit into from
Sep 29, 2024
Merged

Downsize model-loader image #179

InftyAI-Agent merged 1 commit into from
Sep 29, 2024

Conversation

@qinguoyi
Copy link
Member

@qinguoyi qinguoyi commented Sep 29, 2024

What this PR does / why we need it

Downsize model-loader image

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

  1. We use a staged build and using the new dockerfile we see the image reduced from 470MB to 155MB.
image
  1. We tested the old and new images and found that they can all start normally.
    （1）the new image
image (2) the old image image

Does this PR introduce a user-facing change?

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Sep 29, 2024
@qinguoyi qinguoyi mentioned this pull request Sep 29, 2024
Closed
3 tasks
@kerthcet
Copy link
Member

kerthcet commented Sep 29, 2024

Awesome, thanks for this!

/kind cleanup
/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Sep 29, 2024
@InftyAI-Agent InftyAI-Agent merged commit a507bdf into InftyAI:main Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kerthcet kerthcet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qinguoyi @kerthcet @InftyAI-Agent