Fix TCP listening on recreated interface #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pemensik
force-pushed
the
master-bz1721668
branch
from
07670dd to
033f5ae
Compare
Collaborator
Author
|
Thread on upstream archive |
pemensik
force-pushed
the
master-bz1721668
branch
from
033f5ae to
52ced74
Compare
pemensik
force-pushed
the
master-bz1721668
branch
from
52ced74 to
c532ff7
Compare
Log in debug mode listening on interfaces. They can be dynamically found, include interface number, since it is checked on TCP connections. Print also addresses found on them.
On many places return value is ignored. Usually it means port is always the same and not needed to be displayed. Unify warnings.
If interface is recreated with the same address but different index, it would not change any other parameter. Test also address family on incoming TCP queries.
Clean addresses and interfaces not found after enumerate. Free unused records to speed up checking active interfaces and reduce used memory.
Save listening address into listener. Use it to find existing listeners before creating new one. If it exist, increase just used counter. Release only listeners not already used. Duplicates family in listener.
Since address already contain family, remove separate family from listener. Use now family from address itself.
pemensik
force-pushed
the
master-bz1721668
branch
from
c532ff7 to
2fbe4bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when --bind-dynamic is active and interface dnsmasq is listening on is dropped and later recreated. Redhat bug #1728701