Constants #25
Open
Constants #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use repeated literals. Instead provide set of constants to be used instead.
We want cache flush functionality, connect at least existing infrastructure.
Just as non-functional empty stub returning empty list, always.
use NAME, IFACE and PATH suffixed instead of prefixes for constants. Make it more similar with constants in dbus we are using.
Print a bit more details. Share common parts in common methods.
Command line utilities have different reasons to fail. Return basic return codes to indicate reason of the failure. Use Enum class to provide nice list of different values.
Very basic at the moment, but prints just a bit nicer status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define few literals at single place and reuse them more consistently across the code.