feat: Scheduled sending #1619
Open
feat: Scheduled sending #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 unused code occurences Expand |
lebojo
force-pushed
the
feat-Scheduled-sending
branch
7 times, most recently
from
3e2cb04 to
3b6959a
Compare
lebojo
force-pushed
the
feat-Scheduled-sending
branch
2 times, most recently
from
4af1490 to
821485e
Compare
Comment on lines
+33
to
+34
|
|
||
| DraftUtils.editDraft(from: message, mailboxManager: mailboxManager, composeMessageIntent: composeMessageIntent) |
There was a problem hiding this comment.
Context: We had seen together (IRL) that there was a bug: When we modify a draft, it appeared twice (the modified version and the old one) (duplicate bug)
And when we reverted that part of the code it seemed to work again.
Update: I tried to reproduce the bug but I can't do it, it would be necessary to investigate a little more
MailResources/Assets.xcassets/ScheduledSend/disabled-feature-flag.imageset/Group 1000000909.svg
Outdated
Show resolved
Hide resolved
PhilippeWeidmann
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Scheduled messages folder should be treated like the drafts folder:
- No threads
- Remove some actions in the bottom bar in the message details
- Remove some actions in the floating panel for the message "3 dots menu" (maybe even hide it ?)
- Remove the swipe actions
Maybe more ?
We should show a Progress indicator when moving the message back to drafts
valentinperignon
requested changes
Dec 5, 2024
MailResources/Assets.xcassets/ScheduledSend/clock-paperplane.imageset/schedule-send.svg
Outdated
Show resolved
Hide resolved
...sources/Assets.xcassets/ScheduledSend/clock-arrow-counterclockwise.imageset/history-back.svg
Outdated
Show resolved
Hide resolved
Mail/Views/New Message/Scheduled panel/ScheduleOptionButtonRow.swift
Outdated
Show resolved
Hide resolved
Mail/Views/New Message/Scheduled panel/ScheduleOptionButtonRow.swift
Outdated
Show resolved
Hide resolved
Mail/Views/New Message/Scheduled panel/ScheduleOptionButtonRow.swift
Outdated
Show resolved
Hide resolved
Mail/Views/New Message/Scheduled panel/ScheduleOptionButtonRow.swift
Outdated
Show resolved
Hide resolved
Mail/Views/New Message/Scheduled panel/ScheduleSendOptionEnum.swift
Outdated
Show resolved
Hide resolved
lebojo
force-pushed
the
feat-Scheduled-sending
branch
from
67441ca to
f0396c7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the Scheduled Send feature to the infomaniak Mail iOS app, allowing users to schedule emails to be sent at a later time.
Key Changes