feat: Unsubscribe alert #2736
Merged
feat: Unsubscribe alert #2736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baillyjamy
commented
Dec 3, 2025
baillyjamy
commented
baillyjamy
force-pushed
the
unsubscribe-on-mail
branch
from
c7d6ef9 to
503f917
Compare
LunarX
requested changes
Dec 3, 2025
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
baillyjamy
force-pushed
the
unsubscribe-on-mail
branch
from
41c9511 to
fc7e0e8
Compare
FabianDevel
requested changes
Dec 4, 2025
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
baillyjamy
force-pushed
the
unsubscribe-on-mail
branch
from
64432aa to
a76af99
Compare
FabianDevel
requested changes
Dec 4, 2025
Contributor
FabianDevel
left a comment
FabianDevel
left a comment
There was a problem hiding this comment.
Just blocking this because the api isn't ready yet
baillyjamy
force-pushed
the
unsubscribe-on-mail
branch
from
78d518f to
2e3dc64
Compare
FabianDevel
approved these changes
Dec 19, 2025
LunarX
approved these changes
Dec 19, 2025
Contributor
LunarX
left a comment
LunarX
left a comment
There was a problem hiding this comment.
Looks good to me, there's just a quick refactor to avoid unnecessary duplication and help when reading the code.
I'm still unsure on how much we want to merge this half working feature, but apart from the error handling, the code is good
…adViewModel.kt Co-authored-by: Gibran Chevalley <32095402+LunarX@users.noreply.github.com>
baillyjamy
force-pushed
the
unsubscribe-on-mail
branch
from
f256cff to
13380df
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.