Open
Conversation
FabianDevel
added
enhancement
FabianDevel
force-pushed
the
password-protected-public-share
branch
from
58b1095 to
679cc1f
Compare
FabianDevel
force-pushed
the
password-protected-public-share
branch
from
679cc1f to
0482e15
Compare
FabianDevel
force-pushed
the
password-protected-public-share
branch
from
0482e15 to
671e192
Compare
benjaminVadon
force-pushed
the
password-protected-public-share
branch
from
671e192 to
f553c07
Compare
benjaminVadon
force-pushed
the
password-protected-public-share
branch
from
f9bbf83 to
589bca9
Compare
benjaminVadon
force-pushed
the
password-protected-public-share
branch
from
589bca9 to
2b01b20
Compare
Comment on lines
+466
to
+469
| fun String.appendQuery(query: String): String { | ||
| val querySeparator = if (contains("?")) "&" else "?" | ||
| return this + querySeparator + query | ||
| } |
Contributor
There was a problem hiding this comment.
Why not use Uri.Builder or buildUrl from ktor to manage all the case of ApiRoutes ?
Comment on lines
358
to
366
| with(publicShareViewModel) { | ||
| val emptyFilesResult = PublicShareFilesResult(files = emptyList(), shouldUpdate = false, isNewSort = false) | ||
| childrenLiveData.value = emptyFilesResult | ||
| cancelDownload() | ||
|
|
||
| if (folderId == ROOT_SHARED_FILE_ID || rootSharedFile.value == null) { | ||
| if (folderId == ROOT_SHARED_FILE_ID || !isFolder()) { | ||
| downloadPublicShareRootFile() | ||
| } else { | ||
| getFiles(folderId, fileListViewModel.sortType, isNewSort) |
Contributor
There was a problem hiding this comment.
Could be all moved in a method in PublicShareViewModel, what do you think ?
…ymore The problem was because fileId came directly from the activity navargs, but when coming from the password fragment, it was not updated. So the root file download had a bad id
…ate the risk of taking it for the same thing as folderId
…ave the data for the previews/thumbnails
FabianDevel
force-pushed
the
password-protected-public-share
branch
from
2b01b20 to
eaec8d5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the possibility to open a password protected public share directly in the application instead of going to the browser.