feat: Mail validation screen #254

LunarX · 2024-12-16T08:38:23Z

Adds the screen to validate the email.

Is still missing:

Save token for this email address in DB for future uses (we're waiting on KMP version to be updated)
resendEmailCode because (we're waiting on KMP version to be update)
Unknown errors snackbar

Depends on: Infomaniak/multiplatform-SwissTransfer#133

… even when filled to the max

…a argument

…sociated exception

.../com/infomaniak/swisstransfer/ui/screen/newtransfer/validateemail/ValidateUserEmailScreen.kt

...m/infomaniak/swisstransfer/ui/screen/newtransfer/validateemail/ValidateUserEmailViewModel.kt

# Conflicts: # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/ImportFilesViewModel.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt

tevincent · 2024-12-17T14:12:49Z

.../com/infomaniak/swisstransfer/ui/screen/newtransfer/validateemail/ValidateUserEmailScreen.kt

+            horizontalAlignment = layoutStyle.horizontalAlignment,
+        ) {
+            Text(
+                text = stringResource(id = R.string.validateMailTitle),


Do we need to specify id here ?

tevincent

Is it me or the padding between the two buttons and the bottom button with the bottom of the screen is not the same ? Is that intended ?

tevincent · 2024-12-18T07:12:43Z

...m/infomaniak/swisstransfer/ui/screen/newtransfer/validateemail/ValidateUserEmailViewModel.kt

+            _uiState.value = ValidateEmailUiState.Loading
+
+            runCatching {
+                uploadRepository.verifyEmailCode(VerifyEmailCodeBody(otpCode, email))


Since you're using the uploadManager here, maybe we can add a method in uploadManager to call the verifyEmailCode ? uploadManager is used as a common access point for the repository and the controller of uploads so it might be cleaner ?

And if we're a doing that on KMP, we can directly save the token in DB, instead of doing that line 57. Let me know if it'll cause any issue with iOS, as we discussed yesterday as it might interfere with what they did on the native iOS side of things.

Also, we're using the manager to do uploadManager.resendEmailCode(email) so it might be good to do the same thing for everything else.

tevincent · 2024-12-18T07:33:40Z

.../com/infomaniak/swisstransfer/ui/screen/newtransfer/validateemail/components/OtpTextField.kt

+            errorColor: Color = MaterialTheme.colorScheme.error,
+            activeBorderThickness: Dp = 2.dp,
+            inactiveBorderThickness: Dp = 1.dp,
+            shape: RoundedCornerShape = RoundedCornerShape(8.dp),


Suggested change

shape: RoundedCornerShape = RoundedCornerShape(8.dp),

shape: RoundedCornerShape = CustomShapes.SMALL,

tevincent · 2024-12-18T07:38:40Z

.../infomaniak/swisstransfer/ui/screen/newtransfer/validateemail/components/CodeVerification.kt

+import com.infomaniak.swisstransfer.ui.theme.SwissTransferTheme
+import com.infomaniak.swisstransfer.ui.utils.PreviewLightAndDark
+
+private val VALID_CHARACTERS = setOf('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')


Maybe a CharRange ?

private val VALID_CHARACTERS = '0' .. '9'

I tried and it seems to work. Instead of specifying all characters from 0 to 9.

# Conflicts: # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/ImportFilesViewModel.kt

# Conflicts: # app/src/main/java/com/infomaniak/swisstransfer/ui/navigation/NavigationDestination.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/ImportFilesViewModel.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/TransferSendManager.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt

…futur email transfers (Missing KMP)

sonarqubecloud · 2024-12-20T16:06:38Z

Quality Gate passed

Issues
1 New issue
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

LunarX added 24 commits December 12, 2024 09:46

feat: First try at OtpTextField

980ed6a

feat: Basic structure of the user email validation screen

e5c16b6

feat: Import strings

568f676

feat: Control spacing between each character

ebf0b13

refactor: Make it so otp text field always has a "focused" visual cue…

b6c3053

… even when filled to the max

feat: Add isEnabled to OtpTextField

c2f0e7a

feat: Make otp load when a code is entered

db1c674

fix: Correctly filter out forbidden characters

2225e9c

fix: System contextual menu not displaying at the correct coordinates

95fa100

feat: Adapt layout for large screens

b2b0b5c

feat: Make email validation screen scrollable

cbd70db

refactor: Regroup layout style choice with its enum

d349dd4

refactor: Extract OtpTextField to its own file

682200b

refactor: Clean the OtpTextField file and add missing doc/preview

04a427f

feat: Add actions when the topappbar buttons are clicked

15b7fa5

refactor: Reorder enum at the end of the file

033861c

refactor: Remove hardcoded values

afcce96

refactor: Move validate user email files to their own package

8f531ab

feat: Validate email otp code using the correct api route

2670b36

Merge remote-tracking branch 'origin/main' into t3

9513e6b

fix: Adapt to the new button argument signature

76051d8

feat: Add resend email code button timer

8cf9cfa

feat: Disable buttons while the code is being verified

09b8865

feat: Remove "select all" from the current text toolbar

642f23d

LunarX added the enhancement New feature or request label Dec 16, 2024

LunarX requested a review from a team December 16, 2024 08:38

LunarX self-assigned this Dec 16, 2024

LunarX added 2 commits December 16, 2024 11:39

feat: Show snackbar when unknown validation api error occurs

d1ae597

refactor: Keep logic contained inside the inner ValidateUserEmailScreen

0bcbc2d

LunarX force-pushed the mail-validation-ui branch from 4fe805d to 2f92daf Compare December 16, 2024 10:39

LunarX added 2 commits December 16, 2024 14:42

feat: Take user email as nav arg

838ec11

refactor: Use a data class to pass named parameters to method's lambd…

c6954b0

…a argument

LunarX force-pushed the mail-validation-ui branch from 022ae9c to c6954b0 Compare December 16, 2024 14:14

LunarX added 2 commits December 16, 2024 15:16

feat: Extract CodeVerification to its own file

d153401

refactor: Extract ResendCodeCountDownButton to its own file

c09d04c

LunarX marked this pull request as ready for review December 16, 2024 14:41

Merge remote-tracking branch 'origin/main' into mail-validation-ui

3c90939

LunarX marked this pull request as draft December 16, 2024 14:48

feat: Automatically open email validation screen when catching the as…

e731a5a

…sociated exception

LunarX force-pushed the mail-validation-ui branch from 34d7fe5 to e731a5a Compare December 17, 2024 08:18

LunarX marked this pull request as ready for review December 17, 2024 08:18

feat: Open mail apps when clicking on the associated button

c627352

tevincent requested changes Dec 17, 2024

View reviewed changes

.../com/infomaniak/swisstransfer/ui/screen/newtransfer/validateemail/ValidateUserEmailScreen.kt Outdated Show resolved Hide resolved

...m/infomaniak/swisstransfer/ui/screen/newtransfer/validateemail/ValidateUserEmailViewModel.kt Outdated Show resolved Hide resolved

refactor: Use a UiState to define the ValidateUserEmailScreen state

0a5806a

LunarX force-pushed the mail-validation-ui branch from eda972c to 0a5806a Compare December 17, 2024 14:23

LunarX requested a review from tevincent December 17, 2024 14:24

LunarX added 3 commits December 17, 2024 15:31

refactor: Shorten long lines

69f9fdd

Merge remote-tracking branch 'origin/main' into mail-validation-ui

07fef3a

# Conflicts: # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/ImportFilesViewModel.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt

feat: Add resend email code api call to the button

ec33f4e

tevincent requested changes Dec 18, 2024

View reviewed changes

LunarX added 2 commits December 18, 2024 09:30

Merge remote-tracking branch 'origin/main' into mail-validation-ui

4a13692

# Conflicts: # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/ImportFilesViewModel.kt

feat: Update verifyEmailCode call to new kmp version

e776e53

LunarX marked this pull request as draft December 18, 2024 09:11

Merge remote-tracking branch 'origin/main' into mail-validation-ui

3084096

# Conflicts: # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/ImportFilesViewModel.kt

LunarX force-pushed the mail-validation-ui branch from 8cde32f to 3084096 Compare December 18, 2024 15:21

LunarX added 2 commits December 20, 2024 16:32

feat: Validate the user email, store its token and reuse it in every …

6ecf5a5

…futur email transfers (Missing KMP)

LunarX force-pushed the mail-validation-ui branch from 40e505e to 6ecf5a5 Compare December 20, 2024 16:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Mail validation screen #254

feat: Mail validation screen #254

LunarX commented Dec 16, 2024 •

edited

Loading

tevincent Dec 17, 2024

tevincent left a comment

tevincent Dec 18, 2024

tevincent Dec 18, 2024

tevincent Dec 18, 2024

sonarqubecloud bot commented Dec 20, 2024

	shape: RoundedCornerShape = RoundedCornerShape(8.dp),
	shape: RoundedCornerShape = CustomShapes.SMALL,

feat: Mail validation screen #254

Are you sure you want to change the base?

feat: Mail validation screen #254

Conversation

LunarX commented Dec 16, 2024 • edited Loading

tevincent Dec 17, 2024

Choose a reason for hiding this comment

tevincent left a comment

Choose a reason for hiding this comment

tevincent Dec 18, 2024

Choose a reason for hiding this comment

tevincent Dec 18, 2024

Choose a reason for hiding this comment

tevincent Dec 18, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 20, 2024

Quality Gate passed

LunarX commented Dec 16, 2024 •

edited

Loading