Skip to content

Conversation

@karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Aug 14, 2025

Proposed Changes

Timeouts on the query side (grpc) could be streamlined. This PR seeks to remedy this.

  • deprecate current timeout property in ClientConfig as it applies only to the Write API and can lead to confusion.
  • add new writeTimeout property to ClientConfig
  • add new queryTimeout property to ClientConfig, which will be used to calculate default deadlines before query calls are made.
  • Tests for timeouts on both write and query APIs.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.32%. Comparing base (36574b9) to head (99c4057).

Files with missing lines Patch % Lines
...va/com/influxdb/v3/client/config/ClientConfig.java 91.30% 0 Missing and 2 partials ⚠️
...m/influxdb/v3/client/internal/GrpcCallOptions.java 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   87.07%   87.32%   +0.25%     
==========================================
  Files          20       20              
  Lines        1207     1247      +40     
  Branches      188      201      +13     
==========================================
+ Hits         1051     1089      +38     
+ Misses         76       74       -2     
- Partials       80       84       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karel-rehor karel-rehor marked this pull request as ready for review August 15, 2025 12:25
Copy link
Contributor

@jansimonb jansimonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM, thanks! 👍
My only concern is the asymmetry between writeTimetout and queryTimeout: one has a default value, while the other is nullable. However, since this is well documented, it should work as is.

@karel-rehor karel-rehor merged commit caa1722 into main Aug 18, 2025
7 checks passed
@karel-rehor karel-rehor deleted the feat/query-timeout-improvement branch August 18, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants