-
Notifications
You must be signed in to change notification settings - Fork 8
feat: query timeout improvement #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ties added. Next, apply in transports.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 87.07% 87.32% +0.25%
==========================================
Files 20 20
Lines 1207 1247 +40
Branches 188 201 +13
==========================================
+ Hits 1051 1089 +38
+ Misses 76 74 -2
- Partials 80 84 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansimonb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM, thanks! 👍
My only concern is the asymmetry between writeTimetout and queryTimeout: one has a default value, while the other is nullable. However, since this is well documented, it should work as is.
Proposed Changes
Timeouts on the query side (grpc) could be streamlined. This PR seeks to remedy this.
timeoutproperty inClientConfigas it applies only to the Write API and can lead to confusion.writeTimeoutproperty toClientConfigqueryTimeoutproperty toClientConfig, which will be used to calculate default deadlines before query calls are made.Checklist