Skip to content

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Apr 8, 2025

Closes #222 (comment)

Proposed Changes

_ More detail documents about timestamp for query and write functions

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (9008c68) to head (18f1b64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files          18       18           
  Lines        1036     1036           
  Branches      164      164           
=======================================
  Hits          933      933           
  Misses         40       40           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96 NguyenHoangSon96 changed the title fea: timestamp document feat: timestamp document Apr 8, 2025
@NguyenHoangSon96 NguyenHoangSon96 requested a review from Copilot April 8, 2025 02:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/main/java/com/influxdb/v3/client/InfluxDBClient.java:80

  • [nitpick] Consider capitalizing 'Note:' for consistency with common JavaDoc style.
 * note: the timestamp passed will be converted to nanoseconds since the Unix epoch

CHANGELOG.md:6

  • [nitpick] Consider revising the phrasing to 'More detailed documentation about timestamp handling for query and write functions' for improved clarity.
2. [#233](https://github.com/InfluxCommunity/influxdb3-java/pull/233): More detail documents about timestamp for query and write functions

Copy link
Contributor

@jansimonb jansimonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NguyenHoangSon96 NguyenHoangSon96 merged commit e507aab into main Apr 8, 2025
10 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feat/timestamp-document branch April 8, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The documentation or JavaDoc of InfluxDBClient should document the existence of NanosecondConverter

3 participants