Skip to content

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Dec 20, 2024

Closes #33

Proposed Changes

Add queryRows, which return row as a Map

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Dec 20, 2024
@NguyenHoangSon96 NguyenHoangSon96 linked an issue Dec 20, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (27267a9) to head (be410b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   90.14%   90.19%   +0.05%     
==========================================
  Files          19       19              
  Lines        1126     1142      +16     
  Branches      177      178       +1     
==========================================
+ Hits         1015     1030      +15     
  Misses         41       41              
- Partials       70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96
Copy link
Contributor Author

@bednar
I ignored test cases for 2 lines. I think it's unnecessary
But please review and tell me if It's needed

@bednar bednar requested review from karel-rehor and vlastahajek and removed request for bednar January 7, 2025 09:27
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comments requesting a few changes. The ones that I might insist upon are related to examples in javadoc comments, which seem to not show the method being documented. or otherwise appear to be broken.

It would be nice to extend testing.

  • One or two unit tests for new methods would be nice
  • The integration test could be more complete
  • When testing integration it would be nice to test a couple of basic handled exceptional situations.

@NguyenHoangSon96
Copy link
Contributor Author

@karel-rehor
The issues in the documents were my stupid mistakes; I forgot to edit the comment after copying it from query() function 😂
I edited the code, please check again
Thank you

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some issues with the Javadoc examples. The arguments in many of the examples do not match the method they are documenting. Also, when looking at how the javadoc is rendered in Intellij, the formatting of the examples could be improved to be more easily readable.

@NguyenHoangSon96
Copy link
Contributor Author

Hi @karel-rehor
I fixed the comments
Please check again 😊

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Sorry, it took me so long to get back to this. You might need to rebase this PR before merging.

@NguyenHoangSon96
Copy link
Contributor Author

Looks Good. Sorry, it took me so long to get back to this. You might need to rebase this PR before merging.

Hi @karel-rehor
No problem
I have rebased the branch, please check again

@karel-rehor karel-rehor self-requested a review March 11, 2025 09:49
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any significant changes following rebase. Still looks good to go.

Copy link
Contributor

@jansimonb jansimonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@NguyenHoangSon96 NguyenHoangSon96 force-pushed the feature/add-queryRows branch from 2bb7cc2 to 09646f6 Compare June 3, 2025 09:28
@NguyenHoangSon96 NguyenHoangSon96 merged commit 069e805 into main Jun 3, 2025
9 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feature/add-queryRows branch June 3, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add query method returning enumerator over rows

4 participants