Skip to content

Conversation

@alespour
Copy link
Contributor

@alespour alespour commented Jun 27, 2024

Closes #147

Proposed Changes

OSS (Edge) returns slightly different JSON payload on error. A small change in handling it makes the client throw expected InfluxDBException instead of NPE.

Tested with OSS aa28302 and Cloud as of today.

Note: no idea why one of the patch lines is only partially covered by test, and the check fails.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

@alespour alespour marked this pull request as draft June 27, 2024 10:11
@codecov
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.03%. Comparing base (86db636) to head (cec6408).

Files Patch % Lines
...va/com/influxdb/v3/client/internal/RestClient.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   88.59%   89.03%   +0.43%     
==========================================
  Files          16       16              
  Lines         859      866       +7     
  Branches      129      131       +2     
==========================================
+ Hits          761      771      +10     
+ Misses         42       40       -2     
+ Partials       56       55       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour requested review from bednar and karel-rehor June 27, 2024 14:43
@alespour alespour marked this pull request as ready for review June 27, 2024 15:33
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alespour thanks for your PR 👍

LGTM 🚀

@alespour alespour merged commit 8892141 into main Jun 28, 2024
@alespour alespour deleted the fix/oss-compat branch June 28, 2024 08:40
@bednar bednar added this to the 0.9.0 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE on write error

3 participants