Skip to content

Drop HTTP request path as tag #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Conversation

ChrisBr
Copy link
Collaborator

@ChrisBr ChrisBr commented Nov 28, 2018

The HTTP request path contains variable values / parameters.
This does not make it suitable for tags and frequently causes
'exceed tag value limit' errors in InfluxDB.

We had the beta running in production and this caused a 'exceed tag value limit' error within a few hours. I think including the HTTP request path does not make much sense because of it's variable nature.

The HTTP request path contains variable values / parameters.
This does not make it suitable for tags and frequently causes
'exceed tag value limit' errors in InfluxDB.
@ChrisBr
Copy link
Collaborator Author

ChrisBr commented Nov 28, 2018

In #30 is stated

  • Writing the urls that are being written would be interesting

@dmke what do you think? Does it make sense to keep it although potentially you end up with a lot of tags? or should we normalize the path (drop parameters for instance)?

@dmke
Copy link
Collaborator

dmke commented Nov 28, 2018

Yeah, I can see that this is a problem, and dropping parameters won't help much (you can't easily normalize /path/with/embedded/:token/, where :token is a UUID, or another random string). One solution would be to use the route name as tag, but AFAIK the Rails router does not provide a reverse lookup...

I'm OK with dropping the path tag altogether.

@dmke dmke merged commit 2d9b3f6 into InfluxCommunity:1.0-beta Nov 28, 2018
@ChrisBr
Copy link
Collaborator Author

ChrisBr commented Nov 29, 2018

One solution would be to use the route name as tag, but AFAIK the Rails router does not provide a reverse lookup...

I think there would be a way but in the end it would be the same information than the method tag, no (Controller#action vs controller_action_path)?

@ChrisBr
Copy link
Collaborator Author

ChrisBr commented Nov 29, 2018

Anyway, thanks for merging 👍

@dmke
Copy link
Collaborator

dmke commented Nov 29, 2018

but in the end it would be the same information than the method tag

Indeed.

@dmke dmke added this to the 1.0 milestone Dec 1, 2018
@ChrisBr ChrisBr deleted the drop-path branch January 13, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants