Use Module#prepend instead of alias_chaining for rails exceptions #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alias chaining causes an infinite loop when other gems use Module#prepend
|
Sorry for the delay. I'm in the process of merging this now. |
|
This is now included in version 0.1.12. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently alias chaining is used by this gem to tie in to exceptions. This method is now deprecated and it is suggested to use
Module#prepend.This is especially an issue because if another gem Module#prepends onto the same method that is being alias chained it causes an infinite loop and a stack level too deep error. This behavior is talked about here. I was experiencing this exact issue with sentry-raven and based my solution on the one used by sentry-raven
This fix should be backwards compatible with any ruby versions that don't support Module#prepend