use empty package-dir in pyproject.toml #715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #868
this appears to be a known issue stemming from the use of import hooks to comply with pep 660 - see for example python/mypy#13392 and pypa/setuptools#3518. What's happening is that for editable installs
setuptools
creates files like.../site-packages/__editable__.general_superstaq-0.5.5.pth
which are supposed to point python to the source directory. Previously these would just be text files containing a single path, e.g.but after switching to pyproject.toml it becomes an executable hook, e.g.
where
__editable___general_superstaq_0_5_5_finder.py
is another file saved in the site-packages directory. this breaks static analysis tools because they won't execute the required codeafaict this pr seems to be the cleanest workaround - after these changes setuptools seems to generate the old-style
.pth
files (i.e. text files containing paths to the source directories), andmypy
behaves as expected (at least for me)