fix(bilibili): correctly extract video owner names#54
Open
skbeh wants to merge 1 commit intoInfinityLoop1308:mainfrom
Open
fix(bilibili): correctly extract video owner names#54skbeh wants to merge 1 commit intoInfinityLoop1308:mainfrom
skbeh wants to merge 1 commit intoInfinityLoop1308:mainfrom
Conversation
The previous implementation incorrectly used the channels owner name as the uploader for all videos within that channel or playlist. This was because the channel extractor was passing its own name to the video info item extractors. This commit fixes the issue by: - Modifying the `BilibiliChannelInfoItemClientAPIExtractor` and `BilibiliChannelInfoItemWebAPIExtractor` to extract the uploader name from the videos own data. - Correctly passing the uploaders name and avatar to the `BilibiliChannelInfoItemWebAPIExtractor` in the `BilibiliPlaylistExtractor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation incorrectly used the channels owner name as the uploader for all videos within that channel or playlist. This was because the channel extractor was passing its own name to the video info item extractors.
This commit fixes the issue by:
BilibiliChannelInfoItemClientAPIExtractorandBilibiliChannelInfoItemWebAPIExtractorto extract the uploader name from the videos own data.BilibiliChannelInfoItemWebAPIExtractorin the `BilibiliPlaylistExtractor.