Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PineTimeStyle alignment fixes #869

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Conversation

kieranc
Copy link
Contributor

@kieranc kieranc commented Dec 6, 2021

This PR fixes a few minor issues with the PineTimeStyle watchface

  • The rectangle behind the time digits started 5px from the left edge of the screen
  • The initial time digits of 12:34 had the potential to cause alignment issues
  • The notification and bluetooth icons now work as I originally wanted, if only one icon is visible, it is centered below the battery icon, if 2 icons are visible, they go side-by-side.

image
image
image

Copy link
Collaborator

@Avamander Avamander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

Copy link
Contributor

@Riksu9000 Riksu9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to keep the icons in a straight line? I think that would make the most sense for a vertical bar.

src/displayapp/screens/PineTimeStyle.cpp Outdated Show resolved Hide resolved
@kieranc
Copy link
Contributor Author

kieranc commented Dec 6, 2021

@Riksu9000 I tried surrounding the icon alignment if loop with if IsUpdated but it didn't work as I hoped, so I've put the icon alignment loop into a void and I'm running it within the IfUpdated loops... Please let me know what you think of this approach.

@Riksu9000
Copy link
Contributor

@Riksu9000 I tried surrounding the icon alignment if loop with if IsUpdated but it didn't work as I hoped, so I've put the icon alignment loop into a void and I'm running it within the IfUpdated loops... Please let me know what you think of this approach.

Right, because IsUpdated will only return true once.. my bad. Your solution looks great.

Copy link
Member

@geekbozu geekbozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They look great to me. I feel like its a good use of screen space to, There are quite a few more icons I think to get added over time :)

@JF002 JF002 added this to the 1.8.0 milestone Dec 9, 2021
@JF002 JF002 merged commit 645f6f4 into InfiniTimeOrg:develop Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants