-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PineTimeStyle alignment fixes #869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to keep the icons in a straight line? I think that would make the most sense for a vertical bar.
@Riksu9000 I tried surrounding the icon alignment if loop with if IsUpdated but it didn't work as I hoped, so I've put the icon alignment loop into a void and I'm running it within the IfUpdated loops... Please let me know what you think of this approach. |
Right, because IsUpdated will only return true once.. my bad. Your solution looks great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They look great to me. I feel like its a good use of screen space to, There are quite a few more icons I think to get added over time :)
This PR fixes a few minor issues with the PineTimeStyle watchface