Alarm: Display the time until alarm, even if it is off#698
Alarm: Display the time until alarm, even if it is off#698maksalees wants to merge 3 commits intoInfiniTimeOrg:developfrom
Conversation
Previously, if the alarm was turned off, when you pressed the information button, a message was displayed that the alarm was not set. The amount of time until the alarm is now displayed as well as if it is on. What for? Allows you to save two clicks on a button if you just need to see how much time is left before the alarm
Riksu9000
left a comment
Riksu9000
left a comment
There was a problem hiding this comment.
Looks like the alarmTime member might not be needed anymore and could be replaced with the new function. What do you think?
maksalees
force-pushed
the
display-time-until-alarm-even-if-is-off
branch
from
616ee1e to
25034cc
Compare
I agree, I just forgot to fix it 🙂 |
|
Looks good to me! |
|
I have been uaing this pr for some time, works fine and makes using the alarm for measuring time until something easier (don't have to turn alarm on every time). |
… is off Squashed commit of the following: commit 874e1af Author: Maxim Leshchenko <cnmaks90@gmail.com> Date: Wed Sep 29 20:22:58 2021 +0300 Sorry 😂 commit 25034cc Author: Maxim Leshchenko <cnmaks90@gmail.com> Date: Wed Sep 29 19:25:25 2021 +0300 Fixes based on code review commit 77bc346 Author: Maxim Leshchenko <cnmaks90@gmail.com> Date: Tue Sep 28 13:16:50 2021 +0300 Alarm: Display the time until alarm, even if it is off Previously, if the alarm was turned off, when you pressed the information button, a message was displayed that the alarm was not set. The amount of time until the alarm is now displayed as well as if it is on. What for? Allows you to save two clicks on a button if you just need to see how much time is left before the alarm
|
Will this PR be merged? |
|
Well at the moment it is based on quite an old revision of the |
|
@maksalees I'm sorry it's been a long time. Probably the reason why this hasn't been merged is that we're unsure about what's the preferred behaviour. Indeed rebasing this will allow us to take another look at this. |
|
I created a new rebased PR #1346 |
7 participants
Previously, if the alarm was turned off, when you pressed the information button, a message was displayed that the alarm was not set. The amount of time until the alarm is now displayed as well as if it is on.
What for? Allows you to save two clicks on a button if you just need to see how much time is left before the alarm
Before
After