Combine terminal UI improvements and weather addition#2319
Open
JustScott wants to merge 4 commits intoInfiniTimeOrg:mainfrom
Open
Combine terminal UI improvements and weather addition#2319JustScott wants to merge 4 commits intoInfiniTimeOrg:mainfrom
JustScott wants to merge 4 commits intoInfiniTimeOrg:mainfrom
Conversation
|
Build size and comparison to main:
|
Contributor
Author
|
Just a topic of discussion: do you think it would be worthwhile to add a
|
Member
|
I think there's a deeper question: what are the InfiniTime temperature colours, is there a continuous scale, and when discrete steps are needed what temperature does it change at The current thresholds of 0, 4 and 27 seem quite odd to me. 5 and 26°C aren't exactly the same, and I'm not sure about the current colours either What do you think about it? |
+ Reorder code to match the widgets order in the UI. + Moved all objects (rows) into a container + Use InfintimeTheme Colors instead of hardcoded hex values + Added a new InfinitimeTheme color: gray, using it to turn certain values gray when they contain no data + Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964) color to the battery percentage text. + Replaced the 'You have mail.' notification message with the message '[1]+ Notify' to better fit the terminal lore.
fc18832 to
e654a49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the three correlating PRs: #2134, #2135, and #2204 have all been accepted into the
1.16.0release, but won't cleanly merge together, I've created this PR with the conflicts solved while preserving a seperate commit for each.