-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings: Add setting for auto-opening apps #2004
base: main
Are you sure you want to change the base?
Conversation
Build size and comparison to main:
|
6d8e732
to
e9df27a
Compare
I like the sound of this feature, but I think it should be optional. I have my phone and computers all connected with KDE connect, so any audio I play on any device syncs to my phone which sends it to InifiniTime. This is great, but making it switch to the music app every time any audio/media is played anywhere would drive me insane as it'd be switching all the time |
I personally don't think that this would be a very nice user experience. As Mark says, I play media on my phone quite a lot, which will have it start and stop quite frequently. If that causes it to switch to the music app each time, it would get quite annoying. I think that this would be better implemented as a quick-switch action, where you can configure an app to get to quickly. |
e9df27a
to
dfb4e34
Compare
I've added the ability to configure which apps auto-open based on certain events:
|
aef969d
to
da53d2d
Compare
I like this generic solution a lot, my preferred watch face has battery percentage on it so being able to turn off auto battery show would be nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
da53d2d
to
d77f02c
Compare
I understand that such a feature might be useful in some cases but... I would like to challenge it for the following reasons:
As I said, I understand why some users request this kind of feature, but I'm not sure this is the best way to implement it. Feel free to share your opinions :) |
a319aec
to
d5d6c62
Compare
Some of my thoughts about this feature: It should only automatically open apps while the smartwatch is not used for something else; so, basically only while it is on the watch-face. Considering that most of this feature depends on interacting with a companion-app, i think that it may be better to have a way for a companion-app to request opening any app on the smartwatch and keep the settings for wether or not to do it in that companion-app. It would also be good if the companion-app can check for the availability of a smartwatch-app, so it can decide wether or not to offer such a setting, or tell the user how to make it available. Automatically opening an app can make the usage-flow much easier. |
d5d6c62
to
1da02a1
Compare
I updated the patchset to only load the app if there's no app loaded currently.
Great question. Testing this now to see what happens.
Fair point. I think this concern is the only one we cannot address in code and would require a decision from the InfiniTime core team (InfiniTeam? 😛 ) |
1da02a1
to
9c8432f
Compare
I've accounted for this now. The DisplayApp verifies if the app is available before attempting to perform the action.
This is now fixed.
This could be interesting... Gadgetbridge has device-specific settings. InfiniTime could implement a service that allows it to interact with apps.
General users won't be able to decide which app gets installed on their watch.
I agree. This feature's goal is to increase usability. When I play music/podcasts, I expect my watch to know so that I can see/interact. Same with navigation. My companion app (Gadgetbridge) is smart enough that it doesn't just randomly sends any sound/notification as though it were media, and limits it only to actual media playing on my phone (Spotify Lite / AntennaPod). Things like movies from streaming services do not get sent to the watch (which is what I expect anyway), so the behaviour here is really what I would expect of a connected device. |
79ea5ec
to
f9c2dce
Compare
f9c2dce
to
87c6973
Compare
87c6973
to
6987f23
Compare
6987f23
to
9d34d25
Compare
9d34d25
to
25d2f45
Compare
25d2f45
to
efe295e
Compare
efe295e
to
777badf
Compare
fce9fc4
to
1d4ebb3
Compare
1d4ebb3
to
d360f4e
Compare
I was just thinking... what if the app doesn't open right up, but gets placed to the right of the watchface? |
9da21a2
to
c73f8a9
Compare
c73f8a9
to
d7f2e15
Compare
d7f2e15
to
5ee8054
Compare
When starting music on a paired device, the music service will automatically trigger the music app to open if there is no app already loaded.
When a paired device sends a navigation message, the navigation service will automatically trigger the navigation app to open if there is no app already loaded.
Certain apps can be configured to auto-open based on component events: - battery: when charging the watch - music: when playing music from the paired device - navigation: when opening a maps app on the paired device
5ee8054
to
1c569fd
Compare
MusicService: Autostart music app on music startWhen starting music on a paired device, the music service will automatically trigger the music app to open.edit: Repurposed this PR to a more general feature for auto-opening apps.
Certain apps can be configured to auto-open based on component events:
Fixes #1619