Skip to content

Show blue icon when connected, grey when disconnected and hide when disabled#1974

Open
riban-bw wants to merge 2 commits intoInfiniTimeOrg:mainfrom
riban-bw:ble_icon
Open

Show blue icon when connected, grey when disconnected and hide when disabled#1974
riban-bw wants to merge 2 commits intoInfiniTimeOrg:mainfrom
riban-bw:ble_icon

Conversation

@riban-bw
Copy link

This PR changes behaviour of bluetooth icon display.

Previous behaviour was that the icon showed coloured white when enabled and connected.

New behaviou is that the icon shows blue when connected, grey when disconnected and is hidden when disabled. This provides more info in the same space and is consistent with many common implementations which may offer a more familiar workflow.

@github-actions
Copy link

github-actions bot commented Jan 17, 2024

Build size and comparison to main:

Section Size Difference
text 369816B -2812B
data 940B 0B
bss 63516B 0B

@FintasticMan FintasticMan added the UI/UX User interface/User experience label Jan 17, 2024
@minacode
Copy link
Contributor

How is the contrast of the blue icon on the black background? Alternatively white for "connected" would also be an option.

@riban-bw
Copy link
Author

Blue is okay but I did change it to white because it may be simpler and more stylish to have a monochromatic status. I will commit the change to this PR.

@lassogames
Copy link

I just started having some Bluetooth issues with mine and it would certainly help for some high level troubleshooting. I don't really know if my device is broadcasting bluetooth, if the radio is on, or if there is just a connection issue with my phone. Either way this seems like a nice feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI/UX User interface/User experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants